[12.0][FIX] base_jsonify: In odoo 12, Date and Datetime fields values are d… #1711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atetime object Convert fields.Date and fields.Datetime values to string when serializing to json
lmignon
force-pushed
the
12.0-fix-datetime-base-jsonify
branch
from
187130d to
560ba5b
Compare
This was referenced Oct 30, 2019
simahawk
approved these changes
Oct 30, 2019
rousseldenis
approved these changes
Oct 30, 2019
|
/ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
OCA-git-bot
added a commit
that referenced
this pull request
Oct 30, 2019
lmignon
changed the title
|
Congratulations, your PR was merged at feae1f6. Thanks a lot for contributing to OCA. ❤️ |
OCA-git-bot
changed the title
hparfr
reviewed
Oct 30, 2019
| elif field_type == "date": | ||
| value = fields.Date.to_string(value) | ||
| elif field_type == "datetime": | ||
| value = fields.Datetime.to_string(value) |
There was a problem hiding this comment.
I think it's better to be compliant with ISO 8601 here.
Date is ok, but date_time defined here https://github.com/odoo/odoo/blob/12.0/odoo/tools/misc.py#L568
is with a space as separator between dates and time. Plus it's lacking timezone.
There was a problem hiding this comment.
@lmignon have you seen this comment? Sounds important to me too.
There was a problem hiding this comment.
@sbidoul Yes I see it, I'll provide a new PR to fix this.
This was referenced Oct 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…atetime objects
Convert fields.Date and fields.Datetime values to string when serializing to json